Repository navigation
Conversation
github-actions
Bot
added
releases-note/fix
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A.
Rationale for this change
With a SAS token, azblob copy fails with
CannotVerifyCopySource: Copy Blob sends the bare source URL inx-ms-copy-source, and Azure authorizes the source separately from the request URI, which is the only place the SAS gets appended. The block-based copier path already signs its source; the single Copy Blob path doesn't.What changes are included in this PR?
sas_tokento the Copy Blob source URL.Verified against a real storage account (no hierarchical namespace): with a config SAS token, 13 copy and copier behavior tests fail on main with
CannotVerifyCopySourceand pass here; the full suite goes from 120 to 134 passed. Config account key shows no regression. A SAS token from the environment is not covered, same as #8432.Are there any user-facing changes?
azblob copy now works with a SAS token.
Breaking changes
AI Usage Statement
AI-assisted implementation.