Skip to content

chore: upgrade CRoaring to 4.7.1 #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wgtmac merged 2 commits into from
Oct 12, 2026
+23 −1
Merged

chore: upgrade CRoaring to 4.7.1 #1001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaf25a9
chore: upgrade CRoaring to 4.7.1
manuzhang Oct 11, 2026
8fcca34
test: use std::array for portable bitmap fixture
manuzhang Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake_modules/IcebergThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ function(resolve_croaring_dependency)
set(CROARING_URL "$ENV{ICEBERG_CROARING_URL}")
else()
set(CROARING_URL
"https://github.com/RoaringBitmap/CRoaring/archive/refs/tags/v4.4.3.tar.gz")
"https://github.com/RoaringBitmap/CRoaring/archive/refs/tags/v4.7.1.tar.gz")
endif()

fetchcontent_declare(croaring
Expand Down
22 changes: 22 additions & 0 deletions src/iceberg/test/roaring_position_bitmap_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include "iceberg/deletes/roaring_position_bitmap.h"

#include <array>
#include <cstddef>
#include <cstdint>
#include <filesystem>
Expand Down Expand Up @@ -387,6 +388,27 @@ TEST(RoaringPositionBitmapTest, TestSerializeDeserializeRoundTrip) {
AssertEqualContent(copy, {10L, 20L, (int64_t{1} << 32) | 30L});
}

TEST(RoaringPositionBitmapTest, TestPortableLittleEndianEncoding) {
// One bitmap with key 0 and an array container containing position 1.
// Check canonical wire bytes: a same-host round trip can hide endian errors.
constexpr auto kExpected = std::to_array(
"\x01\x00\x00\x00\x00\x00\x00\x00" // Number of bitmaps.
"\x00\x00\x00\x00" // Bitmap key.
"\x3a\x30\x00\x00\x01\x00\x00\x00" // Cookie and number of containers.
"\x00\x00\x00\x00\x10\x00\x00\x00\x01\x00"); // Array container.
const std::string expected(kExpected.data(), kExpected.size() - 1);

RoaringPositionBitmap bitmap;
bitmap.Add(1L);
auto serialized = bitmap.Serialize();
ASSERT_THAT(serialized, IsOk());
EXPECT_EQ(serialized.value(), expected);

auto deserialized = RoaringPositionBitmap::Deserialize(expected);
ASSERT_THAT(deserialized, IsOk());
AssertEqualContent(deserialized.value(), {1L});
}

TEST(RoaringPositionBitmapTest, TestCopyConstructor) {
RoaringPositionBitmap bitmap;
bitmap.Add(10L);
Expand Down
Loading