Repository navigation
chore: upgrade CRoaring to 4.7.1 - #1001
Merged
Merged
Conversation
Include the upstream portable IO endian fix and check canonical little-endian bitmap bytes when serializing and reading.
There was a problem hiding this comment.
🟢 Approval recommended
The dependency update includes the upstream endian fix and the regression test validates both serialization and reading.
0 open findings
What changed in this PR
Upgrades bundled CRoaring to fix big-endian portable serialization identified in #1000.
Changes:
- Updates CRoaring from 4.4.3 to 4.7.1.
- Adds canonical little-endian serialization and deserialization coverage.
| File | Description |
|---|---|
cmake_modules/IcebergThirdpartyToolchain.cmake |
Updates the bundled CRoaring URL. |
src/iceberg/test/roaring_position_bitmap_test.cc |
Verifies canonical portable wire bytes. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Preserve the fixture's embedded zeros and exact wire length while satisfying modernize-avoid-c-arrays.
zhjwpku
approved these changes
Oct 11, 2026
zhjwpku
added
the
ready to merge
wgtmac
removed
the
ready to merge
wgtmac
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1000. Include the upstream portable IO endian fix and check canonical little-endian bitmap bytes when serializing and reading.