Skip to content

PostgreSQL: Parse WITH options of a role membership GRANT - #2733

Merged
LucaCappelletti94 merged 2 commits into
upstream/postgres-grant-role-membershipfrom
upstream/postgres-grant-role-options
Oct 28, 2026
Merged

LucaCappelletti94 merged 2 commits into
upstream/postgres-grant-role-membershipfrom
upstream/postgres-grant-role-options

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

GRANT bypasser TO anon WITH SET FALSE failed with Expected: end of statement, found: WITH. A role membership grant takes WITH name { OPTION | TRUE | FALSE } [, ...], such as WITH ADMIN OPTION or, from PostgreSQL 16, WITH INHERIT FALSE, SET FALSE (GRANT).

GrantRole now keeps them as options. The option name stays an identifier because PostgreSQL's grammar accepts any name there and rejects unknown ones only at execution.

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.38%. Comparing base (e3845d7) to head (a4e71c0).

Additional details and impacted files
@@                             Coverage Diff                             @@
##           upstream/postgres-grant-role-membership    #2733      +/-   ##
===========================================================================
+ Coverage                                    82.37%   82.38%   +0.01%     
===========================================================================
  Files                                           42       42              
  Lines                                        35313    35339      +26     
  Branches                                     35313    35339      +26     
===========================================================================
+ Hits                                         29089    29115      +26     
  Misses                                        2678     2678              
  Partials                                      3546     3546              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 added the enhancement New feature or request label Oct 27, 2026
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/postgres-grant-role-options branch from 99ba252 to a4e71c0 Compare October 28, 2026 07:51
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Thanks @sabir-akhadov-localstack for the review on the stack, I am merging both #2732 and #2733.

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 14eadef Oct 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PostgreSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants