Repository navigation
Drop GRANT role TO role with the access-control warning - #170
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparser main now parses
GRANT role TO granteeasStatement::GrantRole(apache/datafusion-sqlparser-rs#2732, with theWITHoptions from apache/datafusion-sqlparser-rs#2733), where it used to be a parse error. The statement match instatement.rshas no wildcard arm, so pg2sqlite stopped compiling against it, and CI fails on every branch until this lands.A membership grant now drops with the same access-control warning as a privilege
GRANT, since SQLite has no roles and pg2sqlite keeps no role catalog of its own. Which tables the session user's role can read is decided by sql-traitscan_select, and recording memberships there is connetto-rs/sql-traits#164.