GH-51632: [C++][CI] Link OpenTelemetry libs for parquet-arrow-reader-writer-tracing-test depending on System vs Bundled OpenTelemetry - #51633
Merged
Conversation
…eader-writer-tracing-test depending on System vs Bundled OpenTelemetry
|
|
github-actions
Bot
added
awaiting committer review
Member
Author
|
@github-actions crossbow submit test-debian-* test-ubuntu-24.04-cpp-thread-sanitizer |
|
Revision: ca20d7c Submitted crossbow builds: ursacomputing/crossbow @ actions-d3c8597343
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted linkage change addresses the reported system-build failure while preserving bundled-build behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the Parquet tracing test’s OpenTelemetry linkage to support both system and bundled dependencies.
Changes:
- Links all required OpenTelemetry libraries for system installations.
- Retains SDK-only linkage for bundled builds to prevent duplicate globals.
| File | Description |
|---|---|
cpp/src/parquet/CMakeLists.txt |
Selects tracing-test link libraries based on the OpenTelemetry source. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After merging #51606 some debian jobs that use System opentelemetry were failing with missing symbols.
What changes are included in this PR?
Change what we link depending on bundled vs system OpenTelemetry.
Are these changes tested?
Yes all the CI jobs that the previous issue and this new issue had failing have been exercised and are successful
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: