GH-51467: [CI][C++] Remove unused ranges include which breaks R build - #51469
Merged
Merged
Conversation
Member
Author
|
@github-actions crossbow submit test-r-linux-as-cran test-r-macos-as-cran |
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
|
Revision: 07fa44a Submitted crossbow builds: ursacomputing/crossbow @ actions-0376cfb562
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change has no unresolved review issues.
Review effort: Lite
Findings: None
What changed in this PR
Removes the unused C++ <ranges> include that breaks macOS R builds with older toolchains.
Changes:
- Deleted the unused standard-library header.
| File | Description |
|---|---|
cpp/src/arrow/compute/kernels/vector_search_sorted.cc |
Removes the problematic unused include. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
pitrou
approved these changes
Sep 23, 2026
pitrou
left a comment
pitrou
left a comment
Member
There was a problem hiding this comment.
If it's unused, then obvious +1
Member
Author
not only is unused, it breaks some builds :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After:
The nightly CI job for test-r-macos-as-cran failed due to ranges file not found:
What changes are included in this PR?
Remove
#include <ranges>as is never used on the file.Are these changes tested?
Yes via CI
Are there any user-facing changes?
No
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: