Skip to content

records(#1169): correct stale review-status lines in FB and PR-QA - #1199

Merged
amaybaum merged 2 commits into
mainfrom
research/oi-qm-status-fix-20261108
Nov 8, 2026
Merged

amaybaum merged 2 commits into
mainfrom
research/oi-qm-status-fix-20261108

Conversation

@amaybaum

@amaybaum amaybaum commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Records-only correction. Reviewed; waiting for green CI.

Changes

Each line said "review pending". Each now cites the #1189 reviews:

independently model-reviewed: ACCEPT at 1f992246 (#1189 c.6713700281) and delta ACCEPT at 8ca8ce30, the reviewed content (#1189 c.6713781034)

  1. quarter-phase-feedback-20261107/RESULT.md:3. "WIP / author paper result" is kept.
  2. quarter-phase-native-20261107/PROOF-RECOVERY.md:3. "WIP" is kept.
  3. quarter-phase-native-20261107/DESIGN.md:21. This is the heading of the "Forward proof recovery" note. Q-A: feedback control boundary and paper proof repairs #1189 reviewed that recovery's forward changes to DESIGN; Q-A: can OI natively produce the quarter-phase mechanism? (#1169 step 3) #1184 reviewed the original Q-A DESIGN.

Left unchanged by owner decision

  • RESULT.md:188–189: "Independent review of the exact pushed paper is required before its author result can be treated as accepted".
  • PROOF-RECOVERY.md:212: "Independent review of the exact pushed forward patch is required".

Both sentences state a general requirement. The #1189 reviews cited above satisfy it. The sentences do not mean review is still pending.

Evidence

  • Landing: Q-A: feedback control boundary and paper proof repairs #1189 landed all three files as merge 313a93ef, with parents 499463f0 and 8ca8ce30.
  • Review coverage:
    • c.6713700281 gives a full ACCEPT at 1f992246 and covers RESULT, PROOF-RECOVERY and DESIGN.
    • c.6713781034 gives a delta ACCEPT at exactly 8ca8ce30.
  • Byte identity: all three files on main are byte-identical to 8ca8ce30.
  • Reviewer: a model subagent (/root/feedback_review), separate from the author. Hence "model-reviewed".
  • Legacy records: none of the three files is in legacy-records.json.

Review of this PR

Not authorized: merge. That needs green CI, then a separate owner decision.

🤖 Generated with Claude Code

https://claude.ai/code/session_013T6pfKuv5mi3MXtKjH2tZb

@amaybaum
amaybaum marked this pull request as ready for review November 8, 2026 12:35
@amaybaum
amaybaum merged commit f28eb29 into main Nov 8, 2026
75 of 78 checks passed
@amaybaum
amaybaum deleted the research/oi-qm-status-fix-20261108 branch November 8, 2026 12:35

amaybaum commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

Merge record: #1199 (owner-approved, chat, 2026-11-08)

The owner (amaybaum) approved this in chat with the coordinating session on 2026-11-08: "Approve #1199 merge and #1198 integration".

#1199 — Review-status corrections — Approve normal merge — Verify the three reviewed line changes against current main

Before proceeding, confirm green post-merge main CI for #1202.

Merged as f28eb29f26d450808c8d84d49e29294a59f59a94, a merge commit with parents 45eea51d and f6570e9b.

Checks before the merge:

  • Reviewed head: f6570e9b, unchanged.
  • Delta against current main 45eea51d: exactly the three reviewed status lines. They are in quarter-phase-feedback-20261107/RESULT.md:3, quarter-phase-native-20261107/PROOF-RECOVERY.md:3 and quarter-phase-native-20261107/DESIGN.md:21, with 3 lines added and 3 removed.
  • Merge: clean.
  • Main CI on 45eea51d (the A5-Q3: does any A6 extension to affine offsets (E1–E3) have independent justification? (#1049) #1202 merge): green, with 25 successes and 1 skip, on the owner-approved retry of run 42477331971. The earlier attempts failed only at the elan installer download (HTTP 504).
  • PR CI on the head: run 42467235987, 25 successes and 1 skip.

Scope: status-line corrections only. They record that the quarter-phase records were independently model-reviewed (ACCEPT at 1f992246 and delta ACCEPT at 8ca8ce30, #1189 c.6713700281 and c.6713781034). No result, verdict or manuscript changes. Main's push CI is running and will be reported here.


Generated by Claude Code

amaybaum added a commit that referenced this pull request Nov 8, 2026
…tive for Π_A and Π_B)

Owner-approved (chat, 2026-11-08): "#1198 — M-INACC — Approve normal merge after #1199 — Preserve its preregistration, amendments and negative results unchanged." Verified: exactly the five unit files (DESIGN, RESULT, A1–A3), byte-identical to the reviewed head; clean merge onto f28eb29; main CI green on f28eb29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants