Repository navigation
fix(app): native sends clear stale drafts; working and needs-input beat the draft pencil (on da8be25) - #299
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #290: the same change, rebased on ours at da8be25 (after the #296 merge and install 20) without a force-push. #290 stays open until this one merges, and its branch is kept.
Root cause
See #290. The rebase changes nothing in the PR's content.
Change
fix/stale-draft-pencil(cc1efac) is rebased onto da8be25 asfix/stale-draft-pencil-on-da8be25(10498b9, tree 53631f7e292e86b871cc874d922121a5245b8da8).git diff da8be25...cc1efac52 | sha256sum=git diff da8be25 10498b93 | sha256sum= b9053b275918cc7e0364716629d9559a64ea5d3b2e1018259657136c6956326f (8 files, +290/−27).Verification
Run at 10498b9 on the hsrpc worktree, after
pnpm install --frozen-lockfile:turbo run typecheckfor app and thread-listModelReasoningPicker.cold-open.test.tsxtimed out); rerun exit 0, 7,113 passed, 17 skipped. The same suite at da8be25 passed 7,113/0. This PR doesn't touch the model picker.Owner walk: BLOCKED (browser input quarantine) and not run. It will be done after the adapter install. A Hermes clear plus green CI is enough to merge.
No issue: albrand/bb has issues disabled.