Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
On native agent threads, the sidebar showed a draft pencil instead of the Working or Needs input glyph. The owner reported working threads "not showing the icon that displays they are in progress and working too, also not displaying when the thread needs questions answered".
There were two causes:
usePromptDraftStorage). Only submitting through the regular composer, or clearing it, removed that draft. A native thread's input goes through the native prompt bar or the terminal, so sends there, and converting a thread to a native terminal, left the old draft in place.ThreadStatusGlyphlet a saved draft win over active work and pending interaction, so even a correct draft hid Working and Needs input.What changed
NativeTerminalPromptBar.tsx: a native send snapshots the thread's stored composer draft at submit and, on success, clears it only if it still matches (clearIfCurrentMatchesinusePromptDraftStorage.ts). A newer draft written meanwhile, for example in another tab, survives; a failed send clears nothing.native-terminal-mode-action.ts: converting a thread to a native terminal clears it too.ThreadStatusGlyph.tsx: Working and Needs input take precedence over the draft pencil. The pencil shows only for an idle thread with a draft. The thread-list plugin's activity model uses the same order.How you verified
@bb/appsuite: 7,071 passed, 20 skipped. App typecheck passed. The client-core and thread-list plugin checks passed.git diff --checkclean.clear()as a no-op.NativeTerminalPromptBar.test.tsxfor delayed success with a replacement draft and astorageevent, failed-send retention, and other-thread/other-project preservation. The replacement test is RED with an unconditional clear (mutant on a detached clean worktree) and GREEN with the guarded clear. Focused app tests 27/27, app typecheck exit 0, exact-head CI run 40029205559 success.No issue: albrand/bb has GitHub issues disabled.