Skip to content

[PR #13388/203c1c59 backport][3.15] 🧪 Run tests from sdist like downstreams - #13413

Merged
webknjaz merged 2 commits into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz
Aug 17, 2026
Merged

[PR #13388/203c1c59 backport][3.15] 🧪 Run tests from sdist like downstreams#13413
webknjaz merged 2 commits into
aio-libs:3.15from
webknjaz:patchback/backports/3.15/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz

Conversation

@webknjaz

@webknjaz webknjaz commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is a backport of PR #13388 as merged into master (203c1c5). It also includes a backport of a follow-up PR #13430 (7dc43ae).

@webknjaz
webknjaz requested a review from Dreamsorcerer August 13, 2026 23:52
@webknjaz
webknjaz requested a review from asvetlov as a code owner August 13, 2026 23:52
@webknjaz webknjaz added the infra label Aug 13, 2026
@psf-chronographer psf-chronographer Bot added bot:chronographer:provided There is a change note present in this PR labels Aug 13, 2026
@webknjaz webknjaz mentioned this pull request Aug 13, 2026
Merged
5 tasks
@greptile-apps

greptile-apps Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (3): Last reviewed commit: "[PR #13388/203c1c59 backport][3.15] 🧪 R..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.66%. Comparing base (e0273a5) to head (6dd63e4).
⚠️ Report is 11 commits behind head on 3.15.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             3.15   #13413      +/-   ##
==========================================
- Coverage   96.20%   95.66%   -0.55%     
==========================================
  Files         159      160       +1     
  Lines       50895    51183     +288     
  Branches     2772     2828      +56     
==========================================
  Hits        48964    48964              
- Misses       1751     2039     +288     
  Partials      180      180
Flag Coverage Δ
CI-GHA 95.63% <100.00%> (-0.55%) ⬇️
OS-Linux 95.41% <100.00%> (-0.55%) ⬇️
OS-Windows 93.15% <100.00%> (-0.54%) ⬇️
OS-macOS 94.60% <100.00%> (-0.54%) ⬇️
Py-3.10 94.76% <100.00%> (-0.56%) ⬇️
Py-3.11 95.04% <100.00%> (-0.55%) ⬇️
Py-3.12 95.12% <100.00%> (-0.55%) ⬇️
Py-3.13 95.10% <100.00%> (-0.56%) ⬇️
Py-3.14 95.20% <100.00%> (-0.55%) ⬇️
Py-3.14t 94.22% <100.00%> (-0.55%) ⬇️
Py-pypy-3.11 94.08% <100.00%> (-0.54%) ⬇️
VM-macos 94.60% <100.00%> (-0.54%) ⬇️
VM-ubuntu 95.41% <100.00%> (-0.55%) ⬇️
VM-windows 93.15% <100.00%> (-0.54%) ⬇️
cython-coverage 78.05% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 84 untouched benchmarks
⏩ 86 skipped benchmarks1

Comparing webknjaz:patchback/backports/3.15/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz (6dd63e4) with 3.15 (e0273a5)2

Open in CodSpeed

Footnotes

  1. 86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on 3.15 (44486bb) during the generation of this report, so e0273a5 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@webknjaz

webknjaz commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

@Dreamsorcerer would you mind taking over and fixing up the backport?

@webknjaz
webknjaz force-pushed the patchback/backports/3.15/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz branch 2 times, most recently from 7767e05 to cfab9a2 Compare August 16, 2026 21:54
@webknjaz webknjaz mentioned this pull request Aug 16, 2026
Closed
5 tasks
@webknjaz
[PR aio-libs#13430/7dc43ae0 backport][3.15] 🧪 Fix the circular import…
2eeae24 
… branch directory skip

PR aio-libs#13388 introduced partial branch coverage in a directory scan skip
logic in `tests/test_circular_imports.py::test_no_warnings`. This patch
is attempting to address is by bringing the coverage on the test module
back to 100% metric via an explicitly applied "no branch" pragma.

The missing branch coverage only appears in test environments checking
real project installs that are non-editable. Editable installs have a
`aiohttp/.hash/` cache directory that would contain files like
`_http_parser.pyx.hash`, `_cparser.pxd.hash`, `hdrs.py.hash`,
`_find_header.pxd.hash` and `_http_writer.pyx.hash` which speed up
processes in local development environment. The `continue` instruction
would only be hit there.

(cherry picked from commit 7dc43ae)
@webknjaz
[PR aio-libs#13388/203c1c59 backport][3.15] 🧪 Run tests from sdist li…
6dd63e4 
…ke downstreams

Merge PR aio-libs#13388 from branch 'testing/wheel-ci-cd-from-sdist'

(cherry picked from commit 203c1c5)
@webknjaz
webknjaz force-pushed the patchback/backports/3.15/203c1c596818c6bb471fe5c5f50971502959c832/pr-13388/handcrafted-cherry-pick-by-webknjaz branch from cfab9a2 to 6dd63e4 Compare August 17, 2026 13:31
@webknjaz

This comment was marked as outdated.

Sign in to view
1 similar comment
@webknjaz

This comment was marked as outdated.

Sign in to view
@webknjaz
webknjaz merged commit 84e1468 into aio-libs:3.15 Aug 17, 2026
82 of 85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dreamsorcerer Dreamsorcerer Awaiting requested review from Dreamsorcerer
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

@Dreamsorcerer Dreamsorcerer

Labels

bot:chronographer:provided There is a change note present in this PR infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webknjaz @Dreamsorcerer