Skip to content

[PR #13430/7dc43ae0 backport][3.15] 🧪 Fix the circular import branch directory skip - #13434

Closed
patchback[bot] wants to merge 1 commit into
3.15from
patchback/backports/3.15/7dc43ae0926dd9363b71c06b213a74e61a520e39/pr-13430
Closed

[PR #13430/7dc43ae0 backport][3.15] 🧪 Fix the circular import branch directory skip#13434
patchback[bot] wants to merge 1 commit into
3.15from
patchback/backports/3.15/7dc43ae0926dd9363b71c06b213a74e61a520e39/pr-13430

Conversation

@patchback

@patchback patchback Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

This is a backport of PR #13430 as merged into master (7dc43ae).

What do these changes do?

PR #13388 introduced partial branch coverage in a directory scan skip logic in tests/test_circular_imports.py::test_no_warnings. This patch is attempting to address is by bringing the coverage on the test module back to 100% metric.

Are there changes in behavior for the user?

Nah.

Is it a substantial burden for the maintainers to support this?

Nope.

Related issue number

This is just a follow-up for PR #13388.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@patchback
patchback Bot requested a review from asvetlov as a code owner August 16, 2026 21:46
@webknjaz
webknjaz marked this pull request as draft August 16, 2026 21:46
@greptile-apps

greptile-apps Bot commented Aug 16, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge because it only adjusts coverage accounting and comments around unchanged test logic.

The directory-skip condition and control flow are unchanged, and the new annotations match an environment-dependent generated cache directory without affecting aiohttp runtime behavior or public contracts.

Reviews (1): Last reviewed commit: "Merge PR #13430 from branch 'testing/133..." | Re-trigger Greptile

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (e0273a5) to head (5ff2eea).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.15   #13434      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         159      159              
  Lines       50895    50894       -1     
  Branches     2772     2771       -1     
==========================================
- Hits        48964    48963       -1     
  Misses       1751     1751              
  Partials      180      180              
Flag Coverage Δ
CI-GHA 96.17% <100.00%> (-0.01%) ⬇️
OS-Linux 95.96% <100.00%> (-0.01%) ⬇️
OS-Windows 93.68% <100.00%> (-0.01%) ⬇️
OS-macOS 95.13% <100.00%> (-0.01%) ⬇️
Py-3.10 95.30% <100.00%> (-0.01%) ⬇️
Py-3.11 95.59% <100.00%> (-0.01%) ⬇️
Py-3.12 95.67% <100.00%> (+<0.01%) ⬆️
Py-3.13 95.65% <100.00%> (-0.01%) ⬇️
Py-3.14 95.75% <100.00%> (-0.01%) ⬇️
Py-3.14t 94.76% <100.00%> (-0.01%) ⬇️
Py-pypy-3.11 94.61% <100.00%> (-0.01%) ⬇️
VM-macos 95.13% <100.00%> (-0.01%) ⬇️
VM-ubuntu 95.96% <100.00%> (-0.01%) ⬇️
VM-windows 93.68% <100.00%> (-0.01%) ⬇️
cython-coverage 78.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@webknjaz

Copy link
Copy Markdown
Member

DNM: made a part of #13413

@webknjaz webknjaz self-assigned this Aug 16, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 84 untouched benchmarks
⏩ 86 skipped benchmarks1


Comparing patchback/backports/3.15/7dc43ae0926dd9363b71c06b213a74e61a520e39/pr-13430 (5ff2eea) with 3.15 (e0273a5)

Open in CodSpeed

Footnotes

  1. 86 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@webknjaz webknjaz closed this Aug 17, 2026
@webknjaz
webknjaz deleted the patchback/backports/3.15/7dc43ae0926dd9363b71c06b213a74e61a520e39/pr-13430 branch August 17, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant