[PR #13430/7dc43ae0 backport][3.15] 🧪 Fix the circular import branch directory skip - #13434
Conversation
(cherry picked from commit 7dc43ae)
Confidence Score: 5/5The PR appears safe to merge because it only adjusts coverage accounting and comments around unchanged test logic. The directory-skip condition and control flow are unchanged, and the new annotations match an environment-dependent generated cache directory without affecting aiohttp runtime behavior or public contracts. Reviews (1): Last reviewed commit: "Merge PR #13430 from branch 'testing/133..." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.15 #13434 +/- ##
==========================================
- Coverage 96.20% 96.20% -0.01%
==========================================
Files 159 159
Lines 50895 50894 -1
Branches 2772 2771 -1
==========================================
- Hits 48964 48963 -1
Misses 1751 1751
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
DNM: made a part of #13413 |
Merging this PR will not alter performance
Comparing Footnotes
|
This is a backport of PR #13430 as merged into master (7dc43ae).
What do these changes do?
PR #13388 introduced partial branch coverage in a directory scan skip logic in
tests/test_circular_imports.py::test_no_warnings. This patch is attempting to address is by bringing the coverage on the test module back to 100% metric.Are there changes in behavior for the user?
Nah.
Is it a substantial burden for the maintainers to support this?
Nope.
Related issue number
This is just a follow-up for PR #13388.
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.