Repository navigation
Keep a target-only change with a warning instead of a conflict (1.3.0-beta.1) - #258
Merged
Merged
Conversation
An entity changed on the target since the last sync, with the source unchanged, is now skipped with a warning rather than reported as a conflict, for content, pages, models, containers, assets and galleries. A change on both sides is still a conflict, and --overwrite replaces either with the source. The mapping isn't refreshed, so a later source change is caught as a conflict. Kept changes are collected per run (keptTargetChanges): a warning line per entity, a "Target changes kept" section at the end of the run, a preflight warning, and one `targetChangeKept` entry per entity in the --jsonSummary warnings. None of it affects the exit code. Treating these as conflicts was too aggressive: mappings written by older CLI versions often record a target version older than the target's real one, with identical content on both sides. On a clone pair synced by an older CLI, that gave 120 false conflicts on unchanged items. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… the run - drift passes when the receiving side's edit is kept with a target-changed warning. - model.field-rename skips fields another field names in its settings (a linked field's companion ID field). Renaming one leaves the link pointing at a missing field, and the server then drops every value saved to the link. - The conflict edit avoids the item the round's drift edited, so each check grades its own item. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jules-exel
approved these changes
Nov 3, 2026
This was referenced Nov 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes how the sync treats an entity that was changed on the target since the last sync while the source wasn't. 1.3.0-beta.0 made that a conflict. It's now skipped with a warning.
Why
Testing 1.3.0-beta.0 on a clone pair synced by an older CLI found 120 conflicts on items nobody had changed. 115 of the 119 checked had identical fields on both sides, and the other 4 differed only in an asset URL. The target simply had a newer version number than the mapping recorded. Older CLI versions often left the mapping's target version behind the target's real one, and 1.2.x never noticed, because it treated a target-only change as up to date. For anyone upgrading:
--overwrite, the sync exits 1;--overwrite, every one of those items is re-saved for nothing.The rule now
For content, pages, models, containers, assets and galleries:
--overwrite--overwriteThe mapping isn't refreshed for a kept change, so a later source change to it is reported as a conflict instead of silently overwriting the target.
Unchanged:
file_missing) is still a conflict.--syncDeletes"deleted in the source, edited on the target" case is still a conflict.Tracking kept changes
There's a new per-run collector,
keptTargetChanges(src/lib/pushers/kept-target-changes.ts), modelled on the foreign CDN report:targetChangeKeptentry per entity in the--jsonSummarywarnings, withsourceID,targetIDandtargetUrl.None of it affects the counts,
successor the exit code. The README's--overwriteentry describes the rule.CI harness (
ci/permutation/)model.field-renamerenamed a linked field's companion ID field (PermCycleNode.NextID). The link'sLinkeContentDropdownValueFieldthen pointed at a missing field, and the server dropped every value saved to it. The rename now skips fields that another field names in its settings.Tests
--overwrite: update.tsc, ESLint (no errors) and the build.verifyshows only differences that were already there before this run.610455120: every check passes in all 5 rounds, with drift kept with a warning each round.Release
Bumps the version to
1.3.0-beta.1, because1.3.0-beta.0is already published with the strict conflict behaviour. After merging, push thev1.3.0-beta.1tag onmain. The publish workflow runs the sync permutation test on it and, if it passes, publishes it underbeta.🤖 Generated with Claude Code