GUI: Select All / Deselect All act on the filtered list - #100
Merged
Conversation
When a filter is applied, the module list only shows the modules that match it, but Select All and Deselect All still walked the whole list, so they toggled modules the user could not see. Filtering to "chrome" and pressing Select All selected every module in the tool. Both buttons now act on the modules that match the active filter, which is exactly what is on screen. The matching test used by filter_modules is factored into module_matches_filter so the buttons and the list can never disagree about what is visible. With no filter applied the term is empty and matches every module, so the unfiltered behavior is unchanged. Selections made under one filter are left alone when the filter changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
abrignoni
force-pushed
the
fix/select-all-respects-filter
branch
from
July 28, 2026 16:12
e434a38 to
ad09a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a filter is applied the module list only shows matching modules, but Select All / Deselect All still walked the entire list — so they toggled modules that were not on screen. Filtering to
chromeand pressing Select All selected every module in the tool.Both buttons now act on the modules matching the active filter (i.e. exactly what is displayed). The match test used by
filter_modulesis factored into a sharedmodule_matches_filter()so the buttons and the list can never disagree about what counts as visible.No regression when unfiltered: an empty filter term matches every module, so
Select Allwith no filter behaves exactly as before. Selections made under one filter are left untouched when the filter changes.Verified: compiles; behavioral test covers unfiltered select/deselect, filtered select (only matching modules toggled), persistence across filter changes, and filtered deselect; 0 new pylint warnings (file counts identical before/after).
🤖 Generated with Claude Code
Applied to both
vleappGUI.pyand the parallelileappGUI.pycopy in this repo so the two do not drift.