Remove the stale ileappGUI.py copy - #101
Merged
Merged
Conversation
VLEAPP shipped an ileappGUI.py alongside vleappGUI.py. It is an unmodified iLEAPP GUI that was never adapted: it imports leapp_version from scripts.version_info, which VLEAPP does not define (only leapp_name, vleapp_version and vleapp_contributors), so the file raises ImportError and cannot run. Its module list also references iOS artifacts that do not exist here - itunes_backup_info, Ph100-UFED-device-values-Plist and logarchive_artifacts. Nothing refers to it: the README, admin/test/scripts/test_entry_points.py and both GitHub workflows all point at vleappGUI.py. Keeping it only invited edits to the wrong file, since it was being updated in parallel with the real GUI. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VLEAPP ships an
ileappGUI.pynext tovleappGUI.py. It is an unmodified iLEAPP GUI that was never adapted to this repo, and it is dead and broken:from scripts.version_info import leapp_name, leapp_version, but VLEAPP'sversion_infoonly definesleapp_name,vleapp_versionandvleapp_contributors→ImportErroron import.itunes_backup_info,Ph100-UFED-device-values-Plistandlogarchive_artifacts— artifacts that do not exist in VLEAPP.admin/test/scripts/test_entry_points.py, and both GitHub workflows (python_lint.yml,python_runtime_contract.yml) all point atvleappGUI.py. A repo-wide grep forileappGUIoutside the file itself returns nothing.The practical cost of keeping it: it was being updated in parallel with the real GUI, so it invited edits to the wrong file — exactly what happened while preparing #100 (the Select All / filter fix), which has since been narrowed to
vleappGUI.pyonly.🤖 Generated with Claude Code