Repository navigation
Wear the look of the other abap2UI5 tools - #13
Merged
Merged
Conversation
The editor moves off Fiori Horizon and onto what the Playground, the AI App Builder and the AI Agent wear. The bar sits on a sunken page, and the tool's name in the accent is a menu of all four tools. The work sits on white 18px cards, the segmented controls are the AI App Builder's pills, buttons are pills, and the type is Inter (fonts/, self-hosted, OFL). The pages workflow copies fonts/. The canvas keeps the UI5 theme chosen for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YZFmEpRdxrjNxTq4x9J4J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Layout Editor moves off Fiori Horizon and onto the look of the Playground, the AI App Builder and the AI Agent. All four tools read as one family. The playground half is in abap2UI5/playground (branch
claude/beautiful-cerf-sm95qv).What changes
wireMenu(). The list is the playground'sTOOLS(src/shell/tool-switch.mjsthere).shell.css, in light and dark.fonts/(OFL,NOTICE.md).pages.yamlnow copiesfonts/.AGENTS.mdandREADME.mdsay so instead of "styled after SAP Fiori Horizon".Tests
npm test(unit) is green.workflow.spec.mjschecks the editor's dark background; the expected colour is updated to the new palette's.render.spec.mjs › kitchen-sink-1 renders(ui5-current) times out. It times out onmainin the same environment too, so it is not caused by this change.Generated by Claude Code