Skip to content

fix(output): show protocol version in card Interfaces #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhicodes-007 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(output): show protocol version in card Interfaces #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a90b1cb
fix(output): show protocol version in card Interfaces
Oct 5, 2026
37874e1
Update test URLs in output_test.go
msampathkumar Oct 12, 2026
d229bf4
Update agent card name in test case
msampathkumar Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/output/output.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,13 @@ func formatCard(card *a2a.AgentCard) string {
if len(card.SupportedInterfaces) > 0 {
sb.WriteString("Interfaces:\n")
for _, iface := range card.SupportedInterfaces {
fmt.Fprintf(&sb, " %-12s %s\n", iface.ProtocolBinding, iface.URL)
// Include protocol version so cards that expose more than one
// (e.g. 0.3 and 1.0 JSONRPC) are distinguishable (#88).
if iface.ProtocolVersion != "" {
fmt.Fprintf(&sb, " %-12s %-6s %s\n", iface.ProtocolBinding, iface.ProtocolVersion, iface.URL)
} else {
fmt.Fprintf(&sb, " %-12s %s\n", iface.ProtocolBinding, iface.URL)
}
}
}

Expand Down
19 changes: 19 additions & 0 deletions internal/output/output_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package output

import (
"bytes"
"strings"
"testing"

"github.com/google/go-cmp/cmp"
Expand Down Expand Up @@ -111,3 +112,21 @@ func TestMessageTextFileParts(t *testing.T) {
})
}
}

func TestFormatCard_InterfacesIncludeProtocolVersion(t *testing.T) {
card := &a2a.AgentCard{
Name: "Example Agent",
Version: "1.0.0",
SupportedInterfaces: []*a2a.AgentInterface{
{URL: "https://example.com/a2a/v03", ProtocolBinding: a2a.TransportProtocolJSONRPC, ProtocolVersion: "0.3"},
{URL: "https://example.com/a2a", ProtocolBinding: a2a.TransportProtocolJSONRPC, ProtocolVersion: a2a.Version},
},
}
out := formatCard(card)
if !strings.Contains(out, "JSONRPC") || !strings.Contains(out, "0.3") || !strings.Contains(out, "1.0") {
t.Fatalf("Interfaces output missing protocol versions:\n%s", out)
}
if !strings.Contains(out, "https://example.com/a2a/v03") {
t.Fatalf("missing interface URL:\n%s", out)
}
}
Loading