Repository navigation
fix(output): show protocol version in card Interfaces - #89
Open
abhicodes-007 wants to merge 3 commits into
Open
abhicodes-007 wants to merge 3 commits into
abhicodes-007 wants to merge 3 commits into
Conversation
formatCard printed only ProtocolBinding and URL, so a card exposing JSONRPC at both 0.3 and 1.0 looked like two identical lines. Include ProtocolVersion when present. Fixes a2aproject#88
Use generic domain name like `example.com`
msampathkumar
left a comment
Member
There was a problem hiding this comment.
Completed a quick testing. Here is the current expected output with this changes.
I wonder if there is a better readability format of showing v1.0 and v0.3.
Name: Example Agent
Description: Demo agent exposing JSON-RPC at two protocol versions plus REST
Version: 1.0.0
Interfaces:
JSONRPC 0.3 https://example.com/a2a/v03
JSONRPC 1.0 https://example.com/a2a
HTTP+JSON https://example.com/rest
Streaming: true
Skills:
echo Echo
Member
|
Leaning on following pattern We can also do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatCardprintsProtocolVersionbeside each interface binding + URL when set.Fixes #88
Test plan
go test ./internal/output/