Skip to content

ci: give the Go suite a 20-minute per-package timeout #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZacxDev merged 1 commit into from
Nov 1, 2026
Merged

ci: give the Go suite a 20-minute per-package timeout #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,10 +212,15 @@ jobs:
# refuses the run unless each named test is IN it and PASSED, so the gate
# cannot stop running quietly — a rename, a deletion or a build tag that
# filters it out fails this step the same way a red walk does.
#
# ⚠ `-timeout 20m`, NOT go test's default 10m, which is PER PACKAGE: under
# -race -cover internal/api took 460-575 s on main's runs and passed 600 s
# on a runner that was slower across every package (agentprovision 123 s vs
# 91 s), panicking mid-suite with nothing hung. A real hang still fails here.
- name: go test, and assert nothing skipped (one run)
run: |
set -o pipefail
go test -race -cover -json ./... | python3 -u tests/verdict.py --echo summary --require TestEveryRouteIsClassifiedForIsolation --require TestNoRouteLetsOneUserReachAnothersData --require TestAnotherUsersWritesNeverReachYourEventStream
go test -race -cover -timeout 20m -json ./... | python3 -u tests/verdict.py --echo summary --require TestEveryRouteIsClassifiedForIsolation --require TestNoRouteLetsOneUserReachAnothersData --require TestAnotherUsersWritesNeverReachYourEventStream

# The e2e aggregate's leg binder (e2e/pick-legs.mjs) is an instrument
# too: its choice and its refusals, each on a synthetic artifact tree.
Expand Down
2 changes: 1 addition & 1 deletion internal/modulegate/ci_verdict_steps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
// ---------------------------------------------------------------------------

var wantVerdictPipes = map[string]string{
"test": "go test -race -cover -json ./... | python3 -u tests/verdict.py --echo summary" +
"test": "go test -race -cover -timeout 20m -json ./... | python3 -u tests/verdict.py --echo summary" +
" --require TestEveryRouteIsClassifiedForIsolation --require TestNoRouteLetsOneUserReachAnothersData --require TestAnotherUsersWritesNeverReachYourEventStream",
"ccd-tmux": "go test -tags tmuxit -race -run '^TestTmux' -json ./cmd/ccd/ | python3 -u tests/verdict.py --echo all",
"mirror-tmux": "go test -tags tmuxit -race -run '^TestTmux' -json ./internal/mirror/ ./internal/mirrorhost/ | python3 -u tests/verdict.py --echo all",
Expand Down
Loading