Repository navigation
ci: give the Go suite a 20-minute per-package timeout - #394
Merged
Merged
Conversation
go test's default timeout is 10 minutes per package. Under -race -cover, internal/api already takes 460-575 s on main's runs, and on a runner that was slower across every package (agentprovision 123 s vs 91 s) it passed 600 s and panicked mid-suite with nothing hung — three times on PR #393, and once on another PR before it. Locally that PR's api package was 362 s against main's 345 s, all tests passing, so the time was the runner's. A real hang still fails, at 20 minutes instead of 10. The pin in internal/modulegate/ci_verdict_steps_test.go is updated to the new line (watched red with the old pin against the new step). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test's default 10-minute per-package timeout is now too tight for internal/api under -race -cover: main's runs take 460–575 s, and on a slower runner (every package slower — agentprovision 123 s vs 91 s) it crosses 600 s and panics with nothing hung. Seen three times on #393 and once on another PR.
Measured locally on one machine, same DB: internal/api 345 s on main vs 362 s on #393, all passing — the overrun was the runner, not a hang.
A real hang still fails, at 20 minutes. The pin test in internal/modulegate is updated (red with the old pin against the new step, green with the new one).
🤖 Generated with Claude Code