Skip to content

vrtd headers: Check for __STDC_VERSION_STDBIT_H__ when importing stdbit.h #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quetric merged 3 commits into from
Sep 8, 2026
Merged

vrtd headers: Check for __STDC_VERSION_STDBIT_H__ when importing stdbit.h #217

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25789df
vrtd tests: do not use stdbit for C++
serbuvlad Sep 2, 2026
ef9fd7f
vrtd: fix buggy implementation of bit_ceil for n = 1
serbuvlad Sep 2, 2026
9cbcd1a
vrtd: change stdbit gate from c++ to __STDC_VERSION_STDBIT_H__
serbuvlad Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions vrt/vrtd/src/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,15 @@ void vrtd_log(int priority, const char *fmt, ...)
*/
const char *uid_to_username(uid_t uid, char *buf, size_t bufsz);

#define HAVE_STDBIT 0

#if defined(__has_include)
# if __has_include(<stdbit.h>)
# include <stdbit.h>
# define HAVE_STDBIT 1
# if defined(__STDC_VERSION_STDBIT_H__) && __STDC_VERSION_STDBIT_H__ >= 202311L
# undef HAVE_STDBIT
# define HAVE_STDBIT 1
# endif
# endif
#endif

Expand Down Expand Up @@ -136,7 +141,7 @@ static inline uint64_t bit_ceil_u64(uint64_t n) {
* @return Smallest power of two >= n, or 0 if not representable.
*/
static inline uint32_t bit_ceil_u32(uint32_t n) {
if (n == 0) return 1u;
if (n <= 1) return 1u;
if (n > 0x80000000u) return 0u; // not representable
return 1u << (32 - __builtin_clz(n - 1)); // GCC/Clang
}
Expand All @@ -146,7 +151,7 @@ static inline uint32_t bit_ceil_u32(uint32_t n) {
* @return Smallest power of two >= n, or 0 if not representable.
*/
static inline uint64_t bit_ceil_u64(uint64_t n) {
if (n == 0) return 1ull;
if (n <= 1) return 1ull;
if (n > 0x8000000000000000ull) return 0ull; // not representable
return 1ull << (64 - __builtin_clzll(n - 1));
}
Expand Down
Loading