vrtd headers: Check for __STDC_VERSION_STDBIT_H__ when importing stdbit.h - #217
Merged
Conversation
Signed-off-by: Vlad-Gabriel Șerbu <vlad_gabriel.serbu@upb.ro>
Signed-off-by: Vlad-Gabriel Șerbu <vlad_gabriel.serbu@upb.ro>
Signed-off-by: Vlad-Gabriel Șerbu <vlad_gabriel.serbu@upb.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard C/C++ allows
stdbit.hto be importable but not define anything (this occurs in the default C++ compiler on Ubuntu 26.04).Therefore, checking for the header is not enough to decide on whether to use these features or fallback to the manual implementation.
__STDC_VERSION_STDBIT_H__must be defined and have a particular value for the features to exist.This PR also fixes a bug in the fallback code for bit_ceil when
n == 1.