Skip to content

fix: restore queue scope, Zammad actor and mobile navigation guards - #306

Merged
stefan-ernst merged 2 commits into
Windshiftapp:mainfrom
Optic00:codex/review-fixes-20261002
Oct 2, 2026
Merged

stefan-ernst merged 2 commits into
Windshiftapp:mainfrom
Optic00:codex/review-fixes-20261002

Conversation

@Optic00

@Optic00 Optic00 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

I fixed four regressions:

  • Collection queues now require the workspace's item.view permission.
  • Moving a collection moves its queues in the same transaction, and concurrent queue writes cannot retain the old workspace. Clearing a workspace with queues returns a validation error; existing global collections remain editable.
  • Zammad completion checks that its configured actor still exists and is active, even when permission data is cached.
  • A delayed 404 from an earlier mobile item no longer navigates away from the current item.

Regression tests live in the companion core-tests PR. The queue scope tests pass with SQLite and PostgreSQL, including concurrent writes. The public quick suite passed. I also updated DOMPurify to 3.4.16 and the resolved devalue dependency to 5.9.4; npm audit reports no known vulnerabilities in the frontend dependency tree.

@Optic00 Optic00 changed the title Restore queue permission and scope checks, guard Zammad completion and stale mobile errors fix: restore queue scope, Zammad actor and mobile navigation guards Oct 2, 2026
@stefan-ernst

Copy link
Copy Markdown
Contributor

thanks for noticing! main is currently in heavy development, did not even catch that one

@stefan-ernst
stefan-ernst merged commit 5c41aad into Windshiftapp:main Oct 2, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants