Skip to content

Make SuggestionMergeViewTests upvoter setup deterministic #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Samwalton9 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make SuggestionMergeViewTests upvoter setup deterministic #1567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions TWLight/resources/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1383,8 +1383,12 @@ def setUpTestData(cls):
SuggestionFactory(company_url=random.choice(cls.company_urls))
for _ in range(cls.suggestion_merge_count)
]
for suggestion in cls.secondary_suggestions:
upvoter_or_author = random.choice(cls.upvoters_or_authors)
# Cycle through upvoters/authors so each is used at least once,
# keeping the merged upvoter count deterministic.
for i, suggestion in enumerate(cls.secondary_suggestions):
upvoter_or_author = cls.upvoters_or_authors[
i % len(cls.upvoters_or_authors)
]
suggestion.author = upvoter_or_author.user
suggestion.upvoted_users.add(upvoter_or_author.user)
suggestion.save()
Expand Down
Loading