Repository navigation
Make SuggestionMergeViewTests upvoter setup deterministic - #1567
Open
Samwalton9 wants to merge 1 commit into
Open
Samwalton9 wants to merge 1 commit into
Samwalton9 wants to merge 1 commit into
Conversation
Secondary suggestions were assigned an author/upvoter via random.choice, so ~1/32 of runs picked the coordinator every time and test_merge_partner_suggestion_view_post failed with 1 != 2. Cycle through the editor and coordinator instead so both are always used. Bug: T440812 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the description in https://phabricator.wikimedia.org/T440812, this fixes a flaky test.
Assisted by Claude Opus 5.5