Skip to content

daqmetadatareader_epochdata_ingested: stop naming carry-087 in the header #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jesshaley merged 2 commits into from
Nov 2, 2026
Merged

daqmetadatareader_epochdata_ingested: stop naming carry-087 in the header #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acd96c9
daqmetadatareader_epochdata_ingested: stop naming carry-087 in the he…
claude Nov 2, 2026
3acba55
Merge origin/V2 into claude/carry-087-uncited
claude Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/did/+did2/+convert/+migrators_j/daqmetadatareader_epochdata_ingested.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@
% + base.json at the locked NDI-matlab `main`, 3cb19a8, as
% +ndi/+daq/metadatareader.m ingest_epochfiles writes it), and pass 1 carries
% it UNTOUCHED, whatever it holds: every field reaches NDI's second pass,
% which places it or carries it (carry-086, carry-087, carry-088; [extra field
% on an ingested stimulus file is malformed]). Its id is read through
% which places it or carries it (carry-086, carry-088; a block field or edge
% outside NDI's template is carry-100, [fields outside the template are
% malformed], NDI-matlab #1144). Its id is read through
% did2.convert.v1read.readBase, so a legacy `ndi_document` identity is read
% too. The renamed path carried a document universalRenames would have
% changed with carry-100 instead; both carry it.
Expand Down
Loading