Repository navigation
daqmetadatareader_epochdata_ingested: stop naming carry-087 in the header - #369
Merged
Merged
Conversation
…ader NDI-matlab #1144 (c648e3d1) moved the second pass's one carry-087 case (a block field or edge outside NDI's template) to carry-100, as [fields outside the template are malformed] directs. This comment was the last DID-matlab mention of carry-087, which did-schema is retiring; tools/check_carry_citations.py R1 fails on any token the register does not hold. Comment only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxKLA8Tbf9cpvDe7fuVeKf
jesshaley
marked this pull request as ready for review
November 2, 2026 03:51
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## V2 #369 +/- ##
=========================
=========================
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment only. NDI-matlab #1144 (c648e3d1) moved the second pass's one carry-087 case (a
daqmetadatareader_epochdata_ingestedblock field, or an edge outside NDI's template) to carry-100, as [fields outside the template are malformed] (Jess Haley, 2026-10-27) directs: one generic row for every class. This header comment in+migrators_j/daqmetadatareader_epochdata_ingested.mwas the last DID-matlab mention of carry-087 (git grep carry-087onV25c6f3c3: this line only). did-schema is retiring the row, andtools/check_carry_citations.pyR1 fails on anycarry-NNNtoken the register does not hold. So this lands first. No code changes.Generated by Claude Code