RPS-10164 Job read commands list view files#109
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces new CLI commands for managing Smartling translation jobs, specifically adding jobs list, jobs view, and jobs files commands along with their corresponding service implementations and tests. Feedback on the changes highlights several critical issues: a bug where the default value of the --limit flag (500) causes a false-positive conflict during file or hashcode searches; a naming conflict between the global persistent --account flag and the new local boolean --account flag; a potential silent overflow when casting negative limit or offset values to uint32; and a potential runtime panic in jobs view if the Issues field in the API response is nil.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Added three read-only jobs subcommands and supporting service logic.
jobs list— list jobs by project, account (--account), or file/hashcode search (--file/--hashcode), with filters (--name,--number,--status,--uid,--project-id,--with-priority), sorting(
--sort-by/--sort-direction), and pagination (--limit/--offset).jobs view <uid|name>— full detail of a single job.jobs files <uid|name>— source files attached to a job, paginated (--limit/--offset).Dropped the unused AccountUID requirement from the existing jobs progress command — name lookup is project-scoped for all jobs commands.
Smartling/api-sdk-go#33