Skip to content

Rps 10164 Jobs read commands list view files#33

Merged
az-smartling merged 3 commits into
masterfrom
RPS-10164_Read_commands_list_view_files
Jun 3, 2026
Merged

Rps 10164 Jobs read commands list view files#33
az-smartling merged 3 commits into
masterfrom
RPS-10164_Read_commands_list_view_files

Conversation

@az-smartling
Copy link
Copy Markdown
Contributor

@az-smartling az-smartling commented Jun 3, 2026

New Job interface methods

  • ListProjectJobs(ctx, projectID, ListProjectJobsParams) - list jobs in a project with name/number/status/UID filters, sorting, and pagination.
  • ListAccountJobs(ctx, accountUID, ListAccountJobsParams) - list jobs across an account (project-id/status filters, withPriority, sorting, pagination).
  • SearchJobs(ctx, projectID, SearchJobsRequest) - find jobs by file URIs, hashcodes, or job UIDs.

Smartling/smartling-cli#109

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request expands the job-related structs and introduces new endpoints for listing project and account jobs, as well as searching jobs by file URIs, hashcodes, or UIDs. The review feedback is highly constructive and identifies several key improvement opportunities: handling potential JSON null values for optional date fields by using string pointers, refactoring repetitive date-parsing logic in toJobDates with a helper closure, validating search parameters in SearchJobs to prevent empty payloads, and adding assertions in unit tests to verify date parsing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread helpers/conversion.go
Comment thread api/job/ent_job.go
Comment thread api/job/ent_job_list.go
Comment thread api/job/ent_job.go
Comment thread api/job/job.go
Comment thread api/job/job_test.go
@az-smartling az-smartling requested review from dimitrystd and junky June 3, 2026 15:10
@az-smartling az-smartling merged commit 3144f66 into master Jun 3, 2026
@az-smartling az-smartling deleted the RPS-10164_Read_commands_list_view_files branch June 3, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant