Rps 10164 Jobs read commands list view files#33
Conversation
There was a problem hiding this comment.
Code Review
This pull request expands the job-related structs and introduces new endpoints for listing project and account jobs, as well as searching jobs by file URIs, hashcodes, or UIDs. The review feedback is highly constructive and identifies several key improvement opportunities: handling potential JSON null values for optional date fields by using string pointers, refactoring repetitive date-parsing logic in toJobDates with a helper closure, validating search parameters in SearchJobs to prevent empty payloads, and adding assertions in unit tests to verify date parsing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
New Job interface methods
ListProjectJobs(ctx, projectID, ListProjectJobsParams)- list jobs in a project with name/number/status/UID filters, sorting, and pagination.ListAccountJobs(ctx, accountUID, ListAccountJobsParams)- list jobs across an account (project-id/status filters, withPriority, sorting, pagination).SearchJobs(ctx, projectID, SearchJobsRequest)- find jobs by file URIs, hashcodes, or job UIDs.Smartling/smartling-cli#109