Repository navigation
Add typed JSON output to config autoupgrade off - #8776
Merged
Merged
Conversation
This was referenced Oct 6, 2026
Contributor
Author
|
/snapit |
isaacroldan
added this pull request to stack #8780
October 6, 2026 08:29
Contributor
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Built from Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261006082749Caution After installing, validate the version by running |
gonzaloriestra
approved these changes
Oct 6, 2026
gonzaloriestra
left a comment
Contributor
There was a problem hiding this comment.
All working as expected and the code is following all the conventions 👍
isaacroldan
force-pushed
the
codex/json-autoupgrade-off
branch
from
October 6, 2026 11:31
8afa272 to
49a6ebe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Let scripts disable automatic upgrades and read the result as JSON.
WHAT is this pull request doing?
Add
--json/-jtoconfig autoupgrade off. Reuse the shared result schema and presenter.Normal output: Auto-upgrade off. You'll need to run
shopify upgradeto update manually.JSON output:
{"enabled":false}.Validation: 36 focused tests, lint, type-check, and build passed locally.
How to manually test your changes?
From the repository root after normal setup:
Both JSON results must contain
enabled: false, with no terminal banner.The schema must require a boolean
enabled. Restore the original setting after testing.Checklist
Stack: #8774 → #8775 → #8776. Merge in this order.