Skip to content

Add typed JSON output to config autoupgrade off - #8776

Merged
isaacroldan merged 1 commit into
codex/json-autoupgrade-onfrom
codex/json-autoupgrade-off
Oct 6, 2026
Merged

isaacroldan merged 1 commit into
codex/json-autoupgrade-onfrom
codex/json-autoupgrade-off

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Let scripts disable automatic upgrades and read the result as JSON.

WHAT is this pull request doing?

Add --json / -j to config autoupgrade off. Reuse the shared result schema and presenter.

Normal output: Auto-upgrade off. You'll need to run shopify upgrade to update manually.

JSON output: {"enabled":false}.

Validation: 36 focused tests, lint, type-check, and build passed locally.

How to manually test your changes?

From the repository root after normal setup:

node packages/cli/bin/dev.js config autoupgrade status
node packages/cli/bin/dev.js config autoupgrade off --json --no-input
node packages/cli/bin/dev.js config autoupgrade status -j
node packages/cli/bin/dev.js config autoupgrade off --json-schema

Both JSON results must contain enabled: false, with no terminal banner.
The schema must require a boolean enabled. Restore the original setting after testing.

Checklist

  • Cross-platform impacts
  • Documentation impacts
  • Analytics impacts
  • Minor changeset

Stack: #8774 → #8775 → #8776. Merge in this order.

@isaacroldan

Copy link
Copy Markdown
Contributor Author

/snapit

@isaacroldan
isaacroldan added this pull request to stack #8780 October 6, 2026 08:29
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Built from 8afa27210a304dbd9224d72817b5e12341026b3e. Workflow run.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261006082749

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected and the code is following all the conventions 👍

@isaacroldan
isaacroldan force-pushed the codex/json-autoupgrade-off branch from 8afa272 to 49a6ebe Compare October 6, 2026 11:31
@isaacroldan
isaacroldan added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 70e93cf Oct 6, 2026
30 of 31 checks passed
@isaacroldan
isaacroldan deleted the codex/json-autoupgrade-off branch October 6, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants