Skip to content

Add typed JSON output to config autoupgrade status - #8774

Merged
isaacroldan merged 1 commit into
mainfrom
codex/json-autoupgrade
Oct 6, 2026
Merged

isaacroldan merged 1 commit into
mainfrom
codex/json-autoupgrade

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Let scripts read the automatic upgrade setting as JSON.

WHAT is this pull request doing?

Add --json / -j to config autoupgrade status. Define the shared result schema and presenter.

Normal output: Auto-upgrade off. You'll need to run shopify upgrade to update manually.

JSON output: {"enabled":false}.

Validation: 27 focused tests, lint, type-check, and build passed locally.

How to manually test your changes?

From the repository root after normal setup:

node packages/cli/bin/dev.js config autoupgrade status
node packages/cli/bin/dev.js config autoupgrade off
node packages/cli/bin/dev.js config autoupgrade status --json
node packages/cli/bin/dev.js config autoupgrade status --json-schema

Expect {"enabled":false}. Repeat after on, using -j, and expect {"enabled":true}.
The schema must require a boolean enabled. Restore the original setting after testing.

Checklist

  • Cross-platform impacts
  • Documentation impacts
  • Analytics impacts
  • Minor changeset

Stack: #8774 → #8775 → #8776. Merge in this order.

@isaacroldan

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Built from a41ce1478d36dcd033184b35e3078e7b85816d4b. Workflow run.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261006081309

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@isaacroldan
isaacroldan force-pushed the codex/json-autoupgrade branch from a41ce14 to 02a0dc0 Compare October 6, 2026 08:24
@isaacroldan isaacroldan changed the title Add typed JSON output to config autoupgrade Add typed JSON output to config autoupgrade status Oct 6, 2026
@isaacroldan

Copy link
Copy Markdown
Contributor Author

/snapit

@isaacroldan
isaacroldan added this pull request to stack #8780 October 6, 2026 08:29
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Built from 02a0dc0b047f584288daef6185c283c0e66c6081. Workflow run.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20261006082742

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@isaacroldan
isaacroldan force-pushed the codex/json-autoupgrade branch from 02a0dc0 to 4ef30a0 Compare October 6, 2026 11:31
@isaacroldan
isaacroldan added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 52f1464 Oct 6, 2026
30 of 31 checks passed
@isaacroldan
isaacroldan deleted the codex/json-autoupgrade branch October 6, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants