Add typed JSON output to theme open - #8639
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
4 tasks done
gonzaloriestra
added this pull request to stack #8646
September 24, 2026 09:23
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 10:04
289efda to
99beb54
Compare
gonzaloriestra
removed this pull request from stack #8646
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
main
to
gonzalo/json-theme-list
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 10:13
99beb54 to
92cc64e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 10:25
92cc64e to
4609957
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 11:56
4609957 to
72d7aca
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 13:46
72d7aca to
5e9b829
Compare
gonzaloriestra
marked this pull request as ready for review
September 24, 2026 14:13
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 24, 2026 14:36
5e9b829 to
bed6431
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 25, 2026 12:28
bed6431 to
f555da0
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
2 times, most recently
from
September 28, 2026 10:25
51f0294 to
f0db90b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 28, 2026 11:39
f0db90b to
1878211
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 28, 2026 11:51
1878211 to
ae5d372
Compare
isaacroldan
approved these changes
Sep 29, 2026
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
September 29, 2026 10:28
ae5d372 to
c53ee3a
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
2 times, most recently
from
September 29, 2026 13:44
3385b52 to
69f2c44
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
2 times, most recently
from
September 29, 2026 14:40
fb5661e to
b88e882
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-open
branch
from
October 1, 2026 08:52
b88e882 to
c1626ee
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme openonly prints links for humans. Scripts need a typed, discoverable result containing the selected theme and its URLs.Part of https://github.com/shop/issues-develop/issues/23695.
WHAT is this pull request doing?
Add
--jsonand a domain-owned result schema. Keep theme selection, terminal text, and browser opening behavior unchanged, with separate execution and presentation.Normal output:
JSON output:
{ "theme": { "id": 1, "name": "My theme", "createdAtRuntime": false, "processing": false, "role": "unpublished" }, "preview_url": "https://store.myshopify.com?preview_theme_id=1", "editor_url": "https://store.myshopify.com/admin/themes/1/editor" }The optional
theme.srcfield is included when available. Refresh the command manifest, README, and generated documentation. Add service, schema, presentation, and real stdout/stderr tests.How to manually test your changes?
Checklist