Add typed JSON output to theme preview - #8645
Open
gonzaloriestra wants to merge 1 commit into
Open
gonzaloriestra wants to merge 1 commit into
gonzaloriestra wants to merge 1 commit into
Conversation
gonzaloriestra
added this pull request to stack #8646
September 24, 2026 09:23
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:04
ebf024f to
fda3575
Compare
gonzaloriestra
removed this pull request from stack #8646
September 24, 2026 10:04
gonzaloriestra
changed the base branch from
gonzalo/json-theme-open
to
gonzalo/json-theme-share
September 24, 2026 10:05
gonzaloriestra
added this pull request to stack #8655
September 24, 2026 10:05
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:13
fda3575 to
f82379b
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 10:25
f82379b to
f8f160d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 11:56
f8f160d to
781de0e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 13:46
781de0e to
a523b13
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:21
a523b13 to
571cd4e
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 24, 2026 14:36
571cd4e to
814fcb9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 11:43
814fcb9 to
ecb184c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 11:59
ecb184c to
a6c90ed
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 25, 2026 12:28
a6c90ed to
8cfc448
Compare
gonzaloriestra
removed this pull request from stack #8655
September 25, 2026 12:28
gonzaloriestra
added this pull request to stack #8673
September 25, 2026 12:29
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
2 times, most recently
from
September 28, 2026 08:59
7174b1d to
b95a217
Compare
gonzaloriestra
marked this pull request as ready for review
September 28, 2026 09:08
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 28, 2026 10:25
b95a217 to
66c617d
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 28, 2026 11:39
66c617d to
0e6253c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
2 times, most recently
from
September 29, 2026 10:28
a440fdb to
a651fb9
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
September 29, 2026 11:11
a651fb9 to
0e73e4c
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
2 times, most recently
from
September 29, 2026 13:44
188cf16 to
ccc8179
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
2 times, most recently
from
September 29, 2026 14:40
56b039f to
86fe745
Compare
gonzaloriestra
force-pushed
the
gonzalo/json-theme-preview
branch
from
October 1, 2026 08:52
86fe745 to
1f370d0
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/base-command.d.ts@@ -35,6 +35,7 @@ declare abstract class BaseCommand extends Command {
argv: string[];
}>;
protected environmentsFilename(): string | undefined;
+ protected validateNonTTYFlags(flags: FlagOutput): void;
protected failMissingNonTTYFlags(flags: FlagOutput, requiredFlags: string[]): void;
private failMissingNonTTYFlagRequirements;
private applicableNonTTYFlagRequirements;
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
theme previewalready emits JSON, but its result has no discoverable schema and its service also renders output and opens the browser.Part of https://github.com/shop/issues-develop/issues/23695.
WHAT is this pull request doing?
Return a typed preview result and move presentation and browser opening into the command. Preserve the compact JSON keys, success messages, file/API errors, and nonfatal browser behavior. Browser failures use typed diagnostics in JSON mode.
Also, the JSON output was previously using stderr, but it was fixed to use stdout. Warnings and other diagnostics stay on stderr.
Normal output:
Matching result:
{"url":"https://abc123.shopifypreview.com","preview_identifier":"abc123"}How to manually test your changes?
Checklist