Repository navigation
Make Oxlint the primary linter - #8208
gonzaloriestra wants to merge 3 commits into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2c31993 to
4fc3b01
Compare
|
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. |
4fc3b01 to
b6d506b
Compare
b6d506b to
256a658
Compare
256a658 to
ef0dd63
Compare
ef0dd63 to
59717ce
Compare
59717ce to
eaffd3c
Compare
541d8a6 to
5580a00
Compare
1863fb1 to
eb5a8ae
Compare
eb5a8ae to
db9dac6
Compare
db9dac6 to
afc2961
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/session.d.ts@@ -151,15 +151,6 @@ export interface EnsureAuthenticatedBusinessPlatformOptions extends EnsureAuthen
* @returns The access token for the Business Platform API.
*/
export declare function ensureAuthenticatedBusinessPlatform(scopes?: BusinessPlatformScope[], options?: EnsureAuthenticatedBusinessPlatformOptions): Promise<string>;
-/**
- * Whether SHOPIFY_SERVICE_ACCOUNT_TOKEN is set, which makes it the automation token the CLI authenticates with.
- *
- * True even when it's empty or set together with another automation token variable. Commands use this to skip logins
- * saved on this machine, and authentication then reports any problem with the variables.
- *
- * @returns True when SHOPIFY_SERVICE_ACCOUNT_TOKEN is set.
- */
-export declare function isServiceAccountTokenSet(): boolean;
/**
* Fails when SHOPIFY_SERVICE_ACCOUNT_TOKEN is set, for commands that can't run with that token.
*
|

WHY are these changes introduced?
This is the third step of the ESLint-to-Oxlint migration. After establishing native Oxlint parity in CI, this layer makes Oxlint authoritative for migrated rules and leaves ESLint responsible only for compatibility gaps.
WHAT is this pull request doing?
oxlint.json, avoiding duplicated checks and rule driftHow to test your changes?
pnpm lint:eslint --output-style=staticpnpm lintpnpm graphql-codegenwith no generated-file changesgit diff --checkThe compatibility-only ESLint pass decreased locally from approximately 19.8 seconds to 16.2 seconds; plugin and parser startup now dominate its remaining runtime.