Skip to content

Decouple Prettier from ESLint - #8204

Open
gonzaloriestra wants to merge 4 commits into
mainfrom
gonzalo/oxlint-01-prettier
Open

gonzaloriestra wants to merge 4 commits into
mainfrom
gonzalo/oxlint-01-prettier

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This is the first step of the ESLint-to-Oxlint migration. It separates formatting from linting so later PRs can change the linter without changing formatting behavior.

WHAT is this pull request doing?

Use explicit TypeScript build references and separate incremental metadata for builds and type checks, preventing parallel tasks from rewriting dependency declarations.

  • add standalone prettier and prettier:fix scripts for the source files currently linted
  • run formatting explicitly in local lint scripts and GitHub Actions
  • format GraphQL codegen output directly with Prettier
  • remove the prettier/prettier ESLint rule while retaining compatibility rules that prevent formatter conflicts
  • move Prettier to the workspace root and remove the direct eslint-plugin-prettier dependency
  • document the standalone formatting commands

How to test your changes?

  • pnpm install --frozen-lockfile
  • pnpm prettier
  • pnpm nx run-many --all --skip-nx-cache --target=lint --output-style=stream
  • verified eslint --print-config does not contain prettier/prettier

gonzaloriestra commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor Author

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 30, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch 3 times, most recently from 8774cb9 to 5e5acc4 Compare July 30, 2026 10:27
@github-actions

Copy link
Copy Markdown
Contributor

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

@github-actions github-actions Bot closed this Sep 6, 2026
@gonzaloriestra gonzaloriestra reopened this Sep 9, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch from 5e5acc4 to 9d73366 Compare September 9, 2026 11:05
@gonzaloriestra
gonzaloriestra added this pull request to stack #8508 September 9, 2026 11:05
@github-actions github-actions Bot closed this Sep 17, 2026
@gonzaloriestra gonzaloriestra added stale-exempt If added, the PR/issue won't be closed by stale-bot and removed no-pr-activity labels Sep 22, 2026
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch from 9d73366 to 3567ef4 Compare September 22, 2026 09:04
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch from 3567ef4 to c52c21d Compare October 1, 2026 12:22
@gonzaloriestra
gonzaloriestra removed this pull request from stack #8508 October 1, 2026 12:23
@gonzaloriestra
gonzaloriestra added this pull request to stack #8726 October 1, 2026 12:23
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review October 2, 2026 08:03
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner October 2, 2026 08:03
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch 2 times, most recently from 125f808 to 891ebcd Compare October 6, 2026 08:05
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner October 6, 2026 08:05
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch from 891ebcd to dfa1680 Compare October 9, 2026 11:00
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch 3 times, most recently from bfe12eb to f4534b5 Compare October 15, 2026 14:50
@gonzaloriestra
gonzaloriestra force-pushed the gonzalo/oxlint-01-prettier branch from f4534b5 to 0d6dfbd Compare October 15, 2026 14:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. stale-exempt If added, the PR/issue won't be closed by stale-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant