Add sidekick summaries to E2E staging configs - #7752
Merged
Conversation
4 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dmerand
approved these changes
Jun 8, 2026
gonzaloriestra
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
The multi-config
app devE2E tests create a syntheticshopify.app.staging.tomlfixture that no longer matches the required app config shape used byapp dev.The default fixture already includes Sidekick metadata, but the in-test staging config did not. That made the E2E scenario fail before it could validate the actual behavior under test: selecting the correct app config with and without
-c.WHAT is this pull request doing?
Adds a minimal
[sidekick]section withextensions_summaryto the generated staging TOML inpackages/e2e/tests/multi-config-dev.spec.tsfor both multi-config E2E cases.This keeps the staging config aligned with the valid app fixture while preserving the test intent:
app dev -c stagingloadsshopify.app.staging.tomlapp devwithout-ccontinues to loadshopify.app.tomlHow to test your changes?
Run the affected E2E spec:
pnpm --filter e2e test tests/multi-config-dev.spec.tsOr run the E2E workflow/check that covers multi-config app dev.
Post-release steps
None.
Checklist