Skip to content

Add sidekick summaries to E2E staging configs - #7752

Merged
alfonso-noriega merged 1 commit into
mainfrom
e2e-sidekick-staging-config
Jun 8, 2026
Merged

Add sidekick summaries to E2E staging configs#7752
alfonso-noriega merged 1 commit into
mainfrom
e2e-sidekick-staging-config

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The multi-config app dev E2E tests create a synthetic shopify.app.staging.toml fixture that no longer matches the required app config shape used by app dev.

The default fixture already includes Sidekick metadata, but the in-test staging config did not. That made the E2E scenario fail before it could validate the actual behavior under test: selecting the correct app config with and without -c.

WHAT is this pull request doing?

Adds a minimal [sidekick] section with extensions_summary to the generated staging TOML in packages/e2e/tests/multi-config-dev.spec.ts for both multi-config E2E cases.

This keeps the staging config aligned with the valid app fixture while preserving the test intent:

  • app dev -c staging loads shopify.app.staging.toml
  • app dev without -c continues to load shopify.app.toml

How to test your changes?

Run the affected E2E spec:

pnpm --filter e2e test tests/multi-config-dev.spec.ts

Or run the E2E workflow/check that covers multi-config app dev.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows) — test fixture TOML only.
  • I've considered possible documentation changes — none needed.
  • I've considered analytics changes to measure impact — none.
  • The change is not user-facing — no changeset required.

@alfonso-noriega
alfonso-noriega requested a review from a team as a code owner June 8, 2026 14:33

alfonso-noriega commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 8, 2026
@alfonso-noriega
alfonso-noriega added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 4d6cb0f Jun 8, 2026
29 checks passed
@alfonso-noriega
alfonso-noriega deleted the e2e-sidekick-staging-config branch June 8, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants