Fix auto-upgrade telemetry reporting order - #7670
Merged
Merged
Conversation
alfonso-noriega
marked this pull request as ready for review
May 29, 2026 14:32
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alfonso-noriega
force-pushed
the
fix-auto-upgrade-telemetry-order
branch
from
May 29, 2026 14:35
3e51c10 to
39cee41
Compare
gonzaloriestra
approved these changes
Jun 1, 2026
alfonso-noriega
force-pushed
the
fix-auto-upgrade-telemetry-order
branch
2 times, most recently
from
June 8, 2026 14:18
e1c91d2 to
ce84ae7
Compare
alfonso-noriega
force-pushed
the
fix-auto-upgrade-telemetry-order
branch
from
June 8, 2026 14:33
ce84ae7 to
2d083de
Compare
alfonso-noriega
changed the base branch from
graphite-base/7670
to
e2e-sidekick-staging-config
June 8, 2026 14:33
4 tasks
alfonso-noriega
force-pushed
the
fix-auto-upgrade-telemetry-order
branch
from
June 8, 2026 14:46
2d083de to
5791669
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/metadata.d.ts@@ -38,6 +38,7 @@ type CmdFieldsFromMonorail = PickByPrefix<MonorailEventPublic, 'cmd_all_'> & Pic
declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
commandStartOptions: {
startTime: number;
+ endTime?: number;
startCommand: string;
startTopic?: string;
startArgs: string[];
@@ -58,6 +59,7 @@ declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>, getAllSensitiveMetadata: () => Partial<{
commandStartOptions: {
startTime: number;
+ endTime?: number;
startCommand: string;
startTopic?: string;
startArgs: string[];
@@ -77,6 +79,7 @@ export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>,
}, "store_", never>>, addPublicMetadata: (getData: ProvideMetadata<CmdFieldsFromMonorail>, onError?: MetadataErrorHandling) => Promise<void>, addSensitiveMetadata: (getData: ProvideMetadata<{
commandStartOptions: {
startTime: number;
+ endTime?: number;
startCommand: string;
startTopic?: string;
startArgs: string[];
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Auto-upgrade result telemetry (
env_auto_upgrade_successand skip reasons) was being added during the postrun auto-upgrade flow after the command analytics event had already been reported. That made the explicit auto-upgrade fields unreliable on the command event.WHAT is this pull request doing?
How to test your changes?
pnpm vitest run packages/cli-kit/src/public/node/hooks/postrun.test.ts packages/cli-kit/src/public/node/analytics.test.tspnpm nx build cli-kitPost-release steps
None.
Checklist
pnpm changeset add