Migrated many schemas to strict validation - #6191
Open
Vessel9817 wants to merge 55 commits into
Open
Conversation
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
As per the [latest docs](https://github.com/SAP-archive/cloud-s4-sdk-pipeline/blob/476e60dc8bdb7989d03e9755f22d0b3096934b5e/configuration.md#artifactdeployment), the requirement for the nonexistent property `repository` was replaced with a requirement for `mavenRepository` and/or `npmRepository`. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Made stricter, many, many type unions. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Made many, many type unions stricter. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Applied a logical xor to `env` and `value`, requiring at least one be present. Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
requested review from
hyperupcall and
madskristensen
as code owners
August 27, 2026 22:40
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a logic bug introduced in 4d0eb4b Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a logic bug introduced in 4ab5335 Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Contributor
|
This has a merge conflict. |
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
commented
Aug 31, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks again! Just to check, do you prefer the individual PR strategy, or are lump PRs like this easier to work with?
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
commented
Sep 3, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
I only ask, because it'd be really easy to:
- cherry-pick a combined PR like this into separate PRs; or
- merge multiple PRs into one grand PR.
As it's not exactly commonplace to be fiddling with a large quantity of unrelated schemas all at once, I would like to hear your thoughts so that we can prevent future misunderstandings and simplify your workflow. I'd happily go as far as to update the contributing guidelines to reflect your preferences, intended for large changes.
Frankly, lacking the experience, I can't imagine reviewing all these commits. I can't thank you both enough for your continued time and dedication.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Patches a bug introduced in 639279b Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each commit modifies a single file, or otherwise applies a single patch. This may be exempt if there is a circular dependency.