Skip to content

Incorporated strict validation in many schemas - #6297

Open
Vessel9817 wants to merge 27 commits into
SchemaStore:masterfrom
Vessel9817:strict-2
Open

Incorporated strict validation in many schemas#6297
Vessel9817 wants to merge 27 commits into
SchemaStore:masterfrom
Vessel9817:strict-2

Conversation

@Vessel9817

Copy link
Copy Markdown
Contributor

This is a continuation of #6191. As reviewal has begun there, I will continue to push changes here in order to prevent the review from not having enough time to catch up on all the changes.

Once again, to ease review, commits should be split to change one schema at a time, when possible. Larger changes should be split into multiple commits or merged in a separate PR.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
…ct.json

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
@madskristensen

Copy link
Copy Markdown
Contributor

This has a merge conflict.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minecraft-*.json may be using additionalProperties inappropriately, meaning to use "properties": { "additionalProperties": { ... } } instead of "properties": { ... }. Additional tests are needed.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
If type is "object," type cannot also be "array."

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd that minecraft-template-pool.json defines a processors property that, when an object, only contains a processors property. #2699 doesn't contain a schema reference, so I'll see what I can dig up.

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionalProperties-properties usage is also intended, corresponding to an NBT compound.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
`(A=>B) <=> !A+B <=> !(A!B)`

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants