Incorporated strict validation in many schemas - #6297
Open
Vessel9817 wants to merge 27 commits into
Open
Conversation
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
requested review from
hyperupcall and
madskristensen
as code owners
September 3, 2026 05:02
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
…ct.json Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Contributor
|
This has a merge conflict. |
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
commented
Sep 5, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
minecraft-*.json may be using additionalProperties inappropriately, meaning to use "properties": { "additionalProperties": { ... } } instead of "properties": { ... }. Additional tests are needed.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
If type is "object," type cannot also be "array." Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Vessel9817
commented
Sep 6, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Seems odd that minecraft-template-pool.json defines a processors property that, when an object, only contains a processors property. #2699 doesn't contain a schema reference, so I'll see what I can dig up.
Vessel9817
commented
Sep 6, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
Nevermind, seems OK.
Vessel9817
commented
Sep 6, 2026
Vessel9817
left a comment
Contributor
Author
There was a problem hiding this comment.
additionalProperties-properties usage is also intended, corresponding to an NBT compound.
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
`(A=>B) <=> !A+B <=> !(A!B)` Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #6191. As reviewal has begun there, I will continue to push changes here in order to prevent the review from not having enough time to catch up on all the changes.
Once again, to ease review, commits should be split to change one schema at a time, when possible. Larger changes should be split into multiple commits or merged in a separate PR.