Repository navigation
Conversation
…builds is ignored, the FutureWarnings being errors since SPSUnipi#67
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #67 the FutureWarnings are errors, and the tests of main fail: the run of 6b409c9 (#67 itself) and that of 46a3912 (after the revert of #62) fail in the same 22 places, all with
LinopySemanticsWarning, e.g.The warning is raised by linopy 0.10 while PyPSA builds its model, about the change of semantics that linopy announces; nothing of this package raises it. Hence #62 was not the cause, and its revert did not fix main.
This keeps the FutureWarnings as errors and ignores that one class. With it the whole suite passes on main with the FutureWarnings as errors: 43 passed and 16 skipped, with
ucblock_solver,tssb_solverandinvestmentblock_solverof SMS++ develop on the PATH.Once this is in, #62 can go back in as it was: I will open a new PR with it.