feat: Disable keepAlive by default for HTTP(S) agents and add agentOp…#6725
Open
davidkna-sap wants to merge 2 commits into
Open
feat: Disable keepAlive by default for HTTP(S) agents and add agentOp…#6725davidkna-sap wants to merge 2 commits into
davidkna-sap wants to merge 2 commits into
Conversation
…tions for configuration
davidkna-sap
force-pushed
the
davidkna-sap_no-alive
branch
from
b336935 to
7bfc3c2
Compare
KavithaSiva
requested changes
Jul 3, 2026
Contributor
There was a problem hiding this comment.
I propose that we stick to keepAlive:true as default as switching it to false disables socket pooling which impacts all users of Cloud SDK.
But, also the agent options can still be exposed via Destination.
In the AI SDK then, we can overwrite the timeout value for the agent options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tions for configuration
Alternative to #6718
Additional comment: #6718 (comment)