fix(http-client): Set higher default timeout of 120s for http(s) agents#6718
Open
davidkna-sap wants to merge 5 commits into
Open
fix(http-client): Set higher default timeout of 120s for http(s) agents#6718davidkna-sap wants to merge 5 commits into
davidkna-sap wants to merge 5 commits into
Conversation
davidkna-sap
commented
Jul 2, 2026
davidkna-sap
left a comment
Member
Author
There was a problem hiding this comment.
Ok, this does not solve the issue as-is, so I think the fix might belong in @sap-ai-sdk.
Nevertheless defaulting to OS-timeouts (presumably the case here) could still be sensible.
Member
Author
|
Axios (should) set |
Member
Author
|
Additional information:
|
KavithaSiva
requested changes
Jul 3, 2026
KavithaSiva
left a comment
Contributor
There was a problem hiding this comment.
I prefer the solution at #6725 with some changes that I have requested for.
Setting a default of 2 mins for pooled socket timeout feels unecessary.
| */ | ||
| export const defaultAgentOptions: https.AgentOptions | http.AgentOptions = { | ||
| keepAlive: true, | ||
| timeout: 120000 |
Contributor
There was a problem hiding this comment.
[q] Any reason why you picked 2 mins specifically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eouts
The global HTTP(S) Agent has a 5s timeout (source).
This is likely the cause of https://github.com/SAP/ai-sdk-js-backlog/issues/603.
Closes SAP/cloud-sdk-backlog#ISSUENUMBER.