Skip to content

test(hooks): accept transport failures without Obsidian server #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rwanbt merged 1 commit into from
Aug 30, 2026
+8 −3
Merged

test(hooks): accept transport failures without Obsidian server #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions hooks/tests/test_hooks_v4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,14 @@ def test_two_concurrent_ends_produce_independent_outcomes(self) -> None:
for label, result in (("a", a), ("b", b)):
with self.subTest(session=label):
self.assertEqual(result.returncode, 0, msg=result.stderr)
# The error is a transport error (HTTP 401), not a
# log-truncation / silent-loss artifact.
self.assertIn("HTTP", result.stdout)
payload = json.loads(result.stdout.strip().splitlines()[0])
metadata = payload["metadata"]
# With no Obsidian server in CI this is a transport failure;
# the invariant is independent persistence reporting, not a
# particular HTTP status.
self.assertIn("sessionSaveError", metadata)
self.assertEqual(metadata.get("needsTriage"), True)
self.assertIn(label[-1] * 4, metadata.get("notePath", ""))


if __name__ == "__main__":
Expand Down