Repository navigation
Licence plates (#17) and phone numbers (#18), with a fix for Cluj - #19
Merged
Merged
Conversation
Follow-up to #17: CJ was missing from PLATE_COUNTIES, so Cluj plates were rejected. Adds a test that all 41 counties and Bucharest are listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqqTowH2NxGHN3urqpLyyY
Resolves the overlap with #17 in README, CHANGELOG and src/index.ts by keeping both validators. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqqTowH2NxGHN3urqpLyyY
This was referenced Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Lands both contributions from @Aaqibhafeezkhan together, unchanged, plus two follow-ups:
validatePlate/isValidPlatefor Romanian licence plates (closes Add a validator for Romanian licence plates #9)validatePhoneRo/isValidPhoneRofor Romanian phone numbers, normalized to E.164 (closes Add a validator for Romanian phone numbers #10)CJ(Cluj) was missing fromPLATE_COUNTIES, so Cluj plates were rejected and feat: add Romanian licence plate validation #17's own tests failed. Adds a test that all 41 counties and Bucharest are listed.src/index.ts; the conflict is resolved by keeping both validators.Checklist
Generated by Claude Code