Repository navigation
feat: add Romanian phone number validation - #18
Merged
Robert-GeorgeDev merged 1 commit intoNov 11, 2026
Merged
Robert-GeorgeDev merged 1 commit into
Robert-GeorgeDev merged 1 commit into
Conversation
Aaqibhafeezkhan
commented
Oct 28, 2026
Aaqibhafeezkhan
left a comment
Aaqibhafeezkhan
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed phone number normalization, supported prefixes, mobile and landline formats, Romanian error messages, and the test cases.
Contributor
Author
|
Please review/merge |
3 tasks done
Owner
|
Thanks @Aaqibhafeezkhan, merged together with #17 in #19. Both PRs touched the same lines in the README and Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatePhoneRoandisValidPhoneRofor Romanian mobile and landline numbers.+40, and0040prefixes and normalize valid numbers to E.164 format.data.normalizedand Romanian error messages for invalid input.Closes #10.