Repository navigation
murdock-worker: pin redis version and fix create_user - #297
Merged
Merged
Conversation
The argc check was not updated after adding the GID creation, leading to a Segfault if no GID was specified due to an out of bounds read access to argv. Also add checks to run.sh to check if the program ran successfully. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
maribu
approved these changes
Sep 30, 2026
Member
cool 💀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Description
There have been two issues hiding in the
murdock-workercontainer.The first one was a "regression" introduced in #266, when I added the Group ID. The argc count check was not updated accordingly, so
create_userwould happily accept only one argument, where it needed two. Setting only one value would cause a Segmentation Fault due to an out of bounds register access inargv.This also requires an additional fix in
RIOT-OS/murdock-worker, which I'll provide soon.I added an additional check to see if the user has been created successfully and if not, a warning message is printed.
The warnings are printed to stderr to avoid weird errors in our CI. Note
echowarn_shis not available here unfortuntely 😅The second issue was with
dwq.dwqpullspydisque-dwqfrom Kaspar https://github.com/kaspar030/pydisque which just hasredisin it'srequirements.txt. Surprisingly, this has never been an issue untilredis 8was released that changed the prototcol and now starts with anRESP3 HELLOmessage that the server does not understand (because it has not been updated yet).Testing Procedure
Unfortunately I haven't saved the error messages, but I have the
murdock-workerrunning again onflatserv, which is my ThinkPad sitting next to me.Before, the Workers would crash with endless
Segmentation Faulterrors and an Exception from Python about the "HELLO" message.This did not affect the workers that were already running because, and this is BAD, the Watchtower Fix from April was not rolled out. Therefore, watchtower does not work on the CI servers and consequently, the
murdock-workerimages have not been updated either.This also means that all the pull requests from the last five months have not been applied to our actual CI pipeline... 🫠