Repository navigation
scripts/murdock-worker: fix create_user, add checks - #10
Merged
Merged
Conversation
Contributor
Author
|
Merging this won't have any immediate effects as the owners/maintainers of the CI servers explicitly run If that wasn't the case, the |
AnnsAnns
approved these changes
Sep 30, 2026
AnnsAnns
left a comment
AnnsAnns
left a comment
Member
There was a problem hiding this comment.
Nice ty, small hint for future generations tho :)
create_user expects a GID as a second parameter after RIOT-OS/riotdocker#266, this was not adapted in the murdock-worker repository. Also, git-cache-rs does not check if the cache directory actually works when calling git-cache init. We check if the environment variable is set and the directory exists or can be created. Co-Authored-By: Claude Opus 5.5 <norely@anthropic.com>
crasbe
force-pushed
the
pr/fix_create_user
branch
from
September 30, 2026 10:37
db04355 to
4f0ced7
Compare
Contributor
Author
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Description
Full explanation, see RIOT-OS/riotdocker#297
create_user expects a GID as a second parameter after RIOT-OS/riotdocker#266, this was not adapted here.
Also, git-cache-rs does not check if the cache directory actually works when calling git-cache init. We check if the environment variable is set and the directory exists or can be created.
Testing Procedure
This has been verified on my local ThinkPad, but the internet connection is not stable enough to support an ongoing build unfortunately. (I have to go through our uni's VPN because otherwise SSH connections fail left and right).
Once RIOT-OS/riotdocker#297 is merged, I'll transition
skyleafand see if it'll cause any issues in the next days and fix them accordingly.