Skip to content

Prevent server crash when editing function headers - #824

Merged
renkun-ken merged 1 commit into
masterfrom
codex/fix-s3-function-header-crash
Oct 29, 2026
Merged

renkun-ken merged 1 commit into
masterfrom
codex/fix-s3-function-header-crash

Conversation

@renkun-ken

@renkun-ken renkun-ken commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Typing sample_result <- dt[, lapply(.SD, function())] while package metadata is pending can send an empty callee name to the navigation index. The resulting error escapes the queued request readiness check and stops the server.

Skip S3 call lookup when the detected call has no callee, including function and control-flow headers. Return an internal error for an unexpected queued readiness failure so later requests can still be served. Add regressions for completion, hover, signature help, and queue recovery.

Testing

  • Provider readiness, S3 dispatch, member providers, completion, signature, server core, index policy, and source readiness tests passed. Two optional S3 tests were skipped because datawizard is not installed.
  • Installed the package into a temporary library and verified completion, signature help, and hover against a live language-server process, followed by a successful signature request.

@renkun-ken
renkun-ken requested a review from eitsupi October 29, 2026 06:31
@renkun-ken
renkun-ken force-pushed the codex/fix-s3-function-header-crash branch from 7d84a2a to 30bd3be Compare October 29, 2026 06:33
@renkun-ken
renkun-ken merged commit 649a82f into master Oct 29, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants