Skip to content

Fix argument completion after member access - #820

Merged
renkun-ken merged 3 commits into
masterfrom
codex/fix-member-argument-completion
Oct 28, 2026
Merged

renkun-ken merged 3 commits into
masterfrom
codex/fix-member-argument-completion

Conversation

@renkun-ken

@renkun-ken renkun-ken commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Typing $ or @ inside a call, such as get($), can fall back to suggesting the enclosing function's arguments when the member receiver cannot be resolved. The same fallback can occur immediately after a quoted member name, such as get(x$"name").

Skip argument and argument-value completion in member-access contexts, including bare, backtick, single-quoted and double-quoted names. Preserve member and slot completion and ordinary argument completion. Handle escaped quotes and accessors on a preceding line without treating operators inside ordinary strings as member access.

Testing: all completion and native-utility tests passed against an isolated installed package, including completion requests immediately after edits. The changed test files passed local lint checks.

@renkun-ken
renkun-ken requested a review from eitsupi October 28, 2026 07:30

@eitsupi eitsupi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by ChatGPT. Approved.

One non-blocking observation:

  • "member_cursor()" does not recognize quoted member access such as "x$"name"" or "x$'name'". Completion immediately after the closing quote may still fall back to the enclosing function's arguments. Consider covering these cases in a follow-up.

No other issues found.

@renkun-ken
renkun-ken merged commit 12f2585 into master Oct 28, 2026
18 checks passed
@randy3k randy3k mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants