Repository navigation
Fix argument completion after member access - #820
Merged
Merged
Conversation
eitsupi
approved these changes
Oct 28, 2026
eitsupi
left a comment
Member
There was a problem hiding this comment.
Reviewed by ChatGPT. Approved.
One non-blocking observation:
- "member_cursor()" does not recognize quoted member access such as "x$"name"" or "x$'name'". Completion immediately after the closing quote may still fall back to the enclosing function's arguments. Consider covering these cases in a follow-up.
No other issues found.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typing
$or@inside a call, such asget($), can fall back to suggesting the enclosing function's arguments when the member receiver cannot be resolved. The same fallback can occur immediately after a quoted member name, such asget(x$"name").Skip argument and argument-value completion in member-access contexts, including bare, backtick, single-quoted and double-quoted names. Preserve member and slot completion and ordinary argument completion. Handle escaped quotes and accessors on a preceding line without treating operators inside ordinary strings as member access.
Testing: all completion and native-utility tests passed against an isolated installed package, including completion requests immediately after edits. The changed test files passed local lint checks.