Fix null errors on live reads and stop leaked API test deployments

Common/Api/LiveAlgorithmResultsJsonConverter.cs

@@ -90,7 +90,7 @@ public override object ReadJson(JsonReader reader, Type objectType, object exist
                 Datacenter = jObject.Value<string>("datacenter"),
                 Public = jObject.Value<bool>("public"),
                 Success = jObject.Value<bool>("success"),
-                Errors = jObject["errors"]?.ToObject<List<string>>()
+                Errors = jObject["errors"]?.ToObject<List<string>>() ?? new List<string>()
             };
 
             if (!liveAlgoResults.Success)

Tests/Api/LiveAlgorithmResultsJsonConverterTests.cs

@@ -65,7 +65,7 @@ public void EveryFieldIsOptional()
             Assert.IsFalse(result.Success);
             Assert.IsNull(result.Status);
             Assert.IsNull(result.DeployId);
-            Assert.IsNull(result.Errors);
+            CollectionAssert.IsEmpty(result.Errors, "Like every other response, a missing errors array reads as no errors");
             Assert.IsNull(result.Stopped);
             Assert.AreEqual(default(DateTime), result.Launched);
             Assert.IsNull(result.Charts);

Tests/Api/ProjectTests.cs

@@ -930,11 +930,12 @@ public void CreatesLiveAlgorithm()
                 Assert.IsTrue(readLiveLogs.Length >= 0, "The length of the logs was negative!");
                 Assert.IsTrue(readLiveLogs.DeploymentOffset >= 0, "The deploymentOffset");
             }
-            catch (Exception ex)
+            catch
             {
-                // Delete the project in case of an error
+                // Stop whatever is running and delete the project in case of an error
+                ApiClient.LiquidateLiveAlgorithm(projectId);
                 Assert.IsTrue(ApiClient.DeleteProject(projectId).Success);
-                throw ex;
+                throw;
             }
 
             // Delete the project